тесты причесаны

backend/tests/Tnsu.ApprovalRoute.IntegrationTests/ApplicationServices/TemplateRouteServiceTests.cs

@@ -7,14 +7,7 @@ using Tnsu.ApprovalRoute.IntegrationTests.Infrastructure;
 
 namespace Tnsu.ApprovalRoute.IntegrationTests.ApplicationServices;
 
-[CollectionDefinition(Name)]
-public sealed class TemplateRouteServiceCollection : ICollectionFixture<PostgresDatabaseFixture>
-{
-    public const string Name = nameof(TemplateRouteServiceCollection);
-}
-
-[Collection(TemplateRouteServiceCollection.Name)]
-public sealed class TemplateRouteServiceTests : IDisposable
+public sealed class TemplateRouteServiceTests : IClassFixture<PostgresDatabaseFixture>
 {
     private static readonly Guid CompanyId = Guid.Parse("00000000-0000-0000-0000-000000000002");
     private static readonly Guid DepartmentId = Guid.Parse("00000000-0000-0000-0000-000000000001");
@@ -30,20 +23,21 @@ public sealed class TemplateRouteServiceTests : IDisposable
         _requestTypeService = _services.GetRequiredService<RequestTypeService>();
     }
 
-    public void Dispose() => _services.Dispose();
-
     private async Task<Guid> CreateRequestTypeAsync(string name) =>
         (await _requestTypeService.CreateAsync(new CreateRequestTypeRequest(name, $"/{name}"), CancellationToken.None)).Value.Id;
 
-    [Fact]
+    [Fact(DisplayName = "Создание маршрута и получение его по Id возвращает сохранённые данные")]
     public async Task CreateAsync_ThenGetAsync_ReturnsCreatedEntity()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Vacation");
 
+        // Action
         var created = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: true),
             CancellationToken.None);
 
+        // Assert
         created.IsSuccess.ShouldBeTrue();
         created.Value.RequestTypeId.ShouldBe(requestTypeId);
 
@@ -52,65 +46,78 @@ public sealed class TemplateRouteServiceTests : IDisposable
         fetched.Value.CompanyId.ShouldBe(CompanyId);
     }
 
-    [Fact]
+    [Fact(DisplayName = "Создание маршрута с несуществующим типом заявки возвращает неуспешный результат")]
     public async Task CreateAsync_UnknownRequestType_ReturnsFailedResult()
     {
+        // Action
         var result = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, Guid.NewGuid(), DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
             CancellationToken.None);
 
+        // Assert
         result.IsFailed.ShouldBeTrue();
     }
 
-    [Fact]
+    [Fact(DisplayName = "Повторное создание маршрута с тем же типом заявки, отделом, компанией и признаком «по проекту» возвращает конфликт")]
     public async Task CreateAsync_DuplicateRoute_ReturnsFailedResult()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Business trip");
         var request = new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false);
-
         var first = await _service.CreateAsync(request, CancellationToken.None);
         first.IsSuccess.ShouldBeTrue();
 
+        // Action
         var duplicate = await _service.CreateAsync(request, CancellationToken.None);
+
+        // Assert
         duplicate.IsFailed.ShouldBeTrue();
     }
 
-    [Fact]
+    [Fact(DisplayName = "Обновление маршрута изменяет тип маршрута и признак необходимости контроля")]
     public async Task UpdateAsync_ChangesFields()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Sick leave");
         var created = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
             CancellationToken.None);
 
+        // Action
         var updated = await _service.UpdateAsync(
             created.Value.Id,
             new UpdateTemplateRouteRequest(RouteType.Parallel, DepartmentId, CompanyId, ByProject: false, RequiresControl: true),
             CancellationToken.None);
 
+        // Assert
         updated.IsSuccess.ShouldBeTrue();
         updated.Value.RouteType.ShouldBe(RouteType.Parallel);
         updated.Value.RequiresControl.ShouldBeTrue();
     }
 
-    [Fact]
+    [Fact(DisplayName = "Удаление маршрута убирает его из базы")]
     public async Task DeleteAsync_RemovesEntity()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Remote work");
         var created = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
             CancellationToken.None);
 
+        // Action
         var deleted = await _service.DeleteAsync(created.Value.Id, CancellationToken.None);
+
+        // Assert
         deleted.IsSuccess.ShouldBeTrue();
 
         var fetched = await _service.GetAsync(created.Value.Id, CancellationToken.None);
         fetched.IsFailed.ShouldBeTrue();
     }
 
-    [Fact]
+    [Fact(DisplayName = "Резолв маршрута по точному совпадению отдела возвращает шаги с нужным статусом")]
     public async Task ResolveAsync_ExactDepartmentMatch_ReturnsMatchingStepsForStatus()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Exact match request");
         var route = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: true),
@@ -123,39 +130,46 @@ public sealed class TemplateRouteServiceTests : IDisposable
                 1, "approver@tnsu.kz", "Lead", ProjectRole.None, HeadType.Chief, RouteStepStatus.Approval, false),
             CancellationToken.None);
 
+        // Action
         var resolved = await _service.ResolveAsync(
             new ResolveTemplateRouteRequest(requestTypeId, "someone@tnsu.kz", null, RouteStepStatus.Approval),
             CancellationToken.None);
 
+        // Assert
         resolved.IsSuccess.ShouldBeTrue();
         resolved.Value.RouteId.ShouldBe(route.Value.Id);
         resolved.Value.Steps.ShouldHaveSingleItem();
         resolved.Value.Steps[0].ExecutorEmail.ShouldBe("approver@tnsu.kz");
     }
 
-    [Fact]
+    [Fact(DisplayName = "Резолв маршрута откатывается на маршрут без отдела, если точного совпадения по отделу нет")]
     public async Task ResolveAsync_NoDepartmentRoute_FallsBackToCompanyWideRoute()
     {
+        // Arrange
         var requestTypeId = await CreateRequestTypeAsync("Company-wide request");
         var route = await _service.CreateAsync(
             new CreateTemplateRouteRequest(RouteType.Sequential, requestTypeId, DepartmentId: null, CompanyId, ByProject: false, RequiresControl: false),
             CancellationToken.None);
 
+        // Action
         var resolved = await _service.ResolveAsync(
             new ResolveTemplateRouteRequest(requestTypeId, "someone@tnsu.kz", null, RouteStepStatus.Execution),
             CancellationToken.None);
 
+        // Assert
         resolved.IsSuccess.ShouldBeTrue();
         resolved.Value.RouteId.ShouldBe(route.Value.Id);
     }
 
-    [Fact]
+    [Fact(DisplayName = "Резолв маршрута с несуществующим типом заявки возвращает неуспешный результат")]
     public async Task ResolveAsync_UnknownRequestType_ReturnsFailedResult()
     {
+        // Action
         var resolved = await _service.ResolveAsync(
             new ResolveTemplateRouteRequest(Guid.NewGuid(), "someone@tnsu.kz", null, RouteStepStatus.Approval),
             CancellationToken.None);
 
+        // Assert
         resolved.IsFailed.ShouldBeTrue();
     }
 }