Заглушка для департамента (#8)

Co-authored-by: gorbenko.pavel <gorbenko.pavel@tansu.kz> Reviewed-on: http://git.tnsu.kz/gorbenko.pavel/tnsu-approval-route/pulls/8
2026-08-07 10:36:53 +00:00
parent 0ffa032ade
commit 1d45780294
14 changed files with 369 additions and 14 deletions
@@ -231,6 +231,115 @@ public sealed class TemplateRouteServiceTests : IClassFixture<PostgresDatabaseFi
        resolved.Value.Steps[1].OrderNo.ShouldBe(2);
    }

+    [Fact(DisplayName = "Резолв маршрута с шагом «Руководитель указанного отдела» без departmentId в запросе — маршрут формируется, шаг с предупреждением")]
+    public async Task ResolveAsync_DepartmentHeadStepWithoutDepartmentId_ReturnsWarningAndNullExecutor()
+    {
+        // Arrange
+        var requestTypeId = await CreateRequestTypeAsync("Department head without id");
+        var route = await _service.CreateAsync(
+            new CreateTemplateRouteRequest(requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
+            CancellationToken.None);
+
+        var stepService = _services.GetRequiredService<TemplateRouteStepService>();
+        await stepService.CreateAsync(
+            route.Value.Id,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.DepartmentHead, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+
+        // Action — departmentId в запросе не передан
+        var resolved = await _service.ResolveAsync(
+            new ResolveTemplateRouteRequest(requestTypeId, "someone@tnsu.kz", null, RouteStepStatus.Approval),
+            CancellationToken.None);
+
+        // Assert
+        resolved.IsSuccess.ShouldBeTrue();
+        resolved.Value.Steps.ShouldHaveSingleItem();
+        resolved.Value.Steps[0].ExecutorEmail.ShouldBeNull();
+        resolved.Value.Steps[0].Warning.ShouldNotBeNull();
+        resolved.Value.Steps[0].Warning.ShouldContain("departmentId");
+    }
+
+    [Fact(DisplayName = "Резолв маршрута с шагом «Руководитель указанного отдела» и переданным departmentId — резолвится через портал")]
+    public async Task ResolveAsync_DepartmentHeadStepWithDepartmentId_ResolvesViaPortalClient()
+    {
+        // Arrange
+        var targetDepartmentId = Guid.Parse("00000000-0000-0000-0000-0000000000aa");
+        var portalClient = new Mock<ITnsuPortalClient>();
+        portalClient
+            .Setup(x => x.GetEmployeeByEmailAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new EmployeeDirectoryInfo(CompanyId, DepartmentId, "ТОО TANSU Construction", "Тестовая должность"));
+        portalClient
+            .Setup(x => x.GetDepartmentHeadEmailAsync(targetDepartmentId, It.IsAny<CancellationToken>()))
+            .ReturnsAsync("head-of-department@tnsu.kz");
+
+        var services = TestServiceProviderFactory.Build(_connectionString, portalClient: portalClient.Object);
+        var routeService = services.GetRequiredService<TemplateRouteService>();
+        var requestTypeService = services.GetRequiredService<RequestTypeService>();
+        var stepService = services.GetRequiredService<TemplateRouteStepService>();
+
+        var requestTypeId = (await requestTypeService.CreateAsync(
+            new CreateRequestTypeRequest("Department head resolved", "/department-head-resolved", null, null, "General"), CancellationToken.None)).Value.Id;
+        var route = await routeService.CreateAsync(
+            new CreateTemplateRouteRequest(requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
+            CancellationToken.None);
+        await stepService.CreateAsync(
+            route.Value.Id,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.DepartmentHead, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+
+        // Action
+        var resolved = await routeService.ResolveAsync(
+            new ResolveTemplateRouteRequest(requestTypeId, "someone@tnsu.kz", null, RouteStepStatus.Approval, DepartmentId: targetDepartmentId),
+            CancellationToken.None);
+
+        // Assert
+        resolved.IsSuccess.ShouldBeTrue();
+        resolved.Value.Steps.ShouldHaveSingleItem();
+        resolved.Value.Steps[0].ExecutorEmail.ShouldBe("head-of-department@tnsu.kz");
+        resolved.Value.Steps[0].Warning.ShouldBeNull();
+    }
+
+    [Fact(DisplayName = "Резолв маршрута с шагом «Руководитель указанного отдела», для которого портал не вернул руководителя — предупреждение")]
+    public async Task ResolveAsync_DepartmentHeadNotFoundByPortal_ReturnsWarning()
+    {
+        // Arrange
+        var targetDepartmentId = Guid.Parse("00000000-0000-0000-0000-0000000000bb");
+        var portalClient = new Mock<ITnsuPortalClient>();
+        portalClient
+            .Setup(x => x.GetEmployeeByEmailAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new EmployeeDirectoryInfo(CompanyId, DepartmentId, "ТОО TANSU Construction", "Тестовая должность"));
+        portalClient
+            .Setup(x => x.GetDepartmentHeadEmailAsync(targetDepartmentId, It.IsAny<CancellationToken>()))
+            .ReturnsAsync((string?)null);
+
+        var services = TestServiceProviderFactory.Build(_connectionString, portalClient: portalClient.Object);
+        var routeService = services.GetRequiredService<TemplateRouteService>();
+        var requestTypeService = services.GetRequiredService<RequestTypeService>();
+        var stepService = services.GetRequiredService<TemplateRouteStepService>();
+
+        var requestTypeId = (await requestTypeService.CreateAsync(
+            new CreateRequestTypeRequest("Department head not found", "/department-head-not-found", null, null, "General"), CancellationToken.None)).Value.Id;
+        var route = await routeService.CreateAsync(
+            new CreateTemplateRouteRequest(requestTypeId, DepartmentId, CompanyId, ByProject: false, RequiresControl: false),
+            CancellationToken.None);
+        await stepService.CreateAsync(
+            route.Value.Id,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.DepartmentHead, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+
+        // Action
+        var resolved = await routeService.ResolveAsync(
+            new ResolveTemplateRouteRequest(requestTypeId, "someone@tnsu.kz", null, RouteStepStatus.Approval, DepartmentId: targetDepartmentId),
+            CancellationToken.None);
+
+        // Assert
+        resolved.IsSuccess.ShouldBeTrue();
+        resolved.Value.Steps.ShouldHaveSingleItem();
+        resolved.Value.Steps[0].ExecutorEmail.ShouldBeNull();
+        resolved.Value.Steps[0].Warning.ShouldNotBeNull();
+        resolved.Value.Steps[0].Warning.ShouldContain(targetDepartmentId.ToString());
+    }
+
    [Fact(DisplayName = "Резолв маршрута включает шаг с условием «больше», когда переданное значение поля его удовлетворяет")]
    public async Task ResolveAsync_ConditionGreaterThan_SatisfiedByFieldValue_IncludesStep()
    {
@@ -85,6 +85,92 @@ public sealed class TemplateRouteStepServiceTests : IClassFixture<PostgresDataba
        duplicate.IsFailed.ShouldBeTrue();
    }

+    [Fact(DisplayName = "Второй шаг с тем же типом руководителя в том же маршруте — конфликт, даже с другим статусом/переназначением")]
+    public async Task CreateAsync_SecondStepWithSameHeadType_ReturnsFailedResult()
+    {
+        // Arrange — тип руководителя резолвится в ОДНОГО конкретного человека
+        // (см. HasDuplicateHeadTypeAsync), поэтому два шага с одним HeadType в
+        // одном маршруте не должны допускаться, даже если остальные поля разные.
+        var routeId = await CreateRouteAsync("Route with duplicate head type", byProject: false);
+        var first = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.Chief, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+        first.IsSuccess.ShouldBeTrue();
+
+        // Action — другой статус (Execution вместо Approval), но тот же HeadType.Chief
+        var second = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(2, null, null, null, HeadType.Chief, RouteStepStatus.Execution, true, null, null, null),
+            CancellationToken.None);
+
+        // Assert
+        second.IsFailed.ShouldBeTrue();
+    }
+
+    [Fact(DisplayName = "Два шага «Руководитель указанного отдела» в одном маршруте — конфликт")]
+    public async Task CreateAsync_TwoDepartmentHeadSteps_ReturnsFailedResult()
+    {
+        // Arrange
+        var routeId = await CreateRouteAsync("Route with duplicate department head", byProject: false);
+        var first = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.DepartmentHead, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+        first.IsSuccess.ShouldBeTrue();
+
+        // Action
+        var second = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(2, null, null, null, HeadType.DepartmentHead, RouteStepStatus.Execution, false, null, null, null),
+            CancellationToken.None);
+
+        // Assert
+        second.IsFailed.ShouldBeTrue();
+    }
+
+    [Fact(DisplayName = "Разные типы руководителя в одном маршруте — допустимы (конфликт только при совпадении HeadType)")]
+    public async Task CreateAsync_DifferentHeadTypes_BothSucceed()
+    {
+        // Arrange
+        var routeId = await CreateRouteAsync("Route with different head types", byProject: false);
+
+        // Action
+        var chief = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.Chief, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+        var directorTansu = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(2, null, null, null, HeadType.DirectorTansu, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+
+        // Assert
+        chief.IsSuccess.ShouldBeTrue();
+        directorTansu.IsSuccess.ShouldBeTrue();
+    }
+
+    [Fact(DisplayName = "Обновление шага, при котором HeadType не меняется, не конфликтует само с собой")]
+    public async Task UpdateAsync_SameHeadTypeOnSameStep_DoesNotConflictWithItself()
+    {
+        // Arrange
+        var routeId = await CreateRouteAsync("Route to update head type on itself", byProject: false);
+        var created = await _service.CreateAsync(
+            routeId,
+            new CreateTemplateRouteStepRequest(1, null, null, null, HeadType.Chief, RouteStepStatus.Approval, false, null, null, null),
+            CancellationToken.None);
+
+        // Action — HasDuplicateHeadTypeAsync должен исключать сам обновляемый шаг (excludeId)
+        var updated = await _service.UpdateAsync(
+            routeId,
+            created.Value.Id,
+            new UpdateTemplateRouteStepRequest(1, null, null, null, HeadType.Chief, RouteStepStatus.Execution, true, null, null, null),
+            CancellationToken.None);
+
+        // Assert
+        updated.IsSuccess.ShouldBeTrue();
+    }
+
    [Fact(DisplayName = "Создание шага только с типом руководителя (без исполнителя, должности и роли) успешно")]
    public async Task CreateAsync_HeadTypeOnly_ReturnsCreatedStep()
    {